Apply masking to messages once the payload has been placed in the fra…

…me buffer rather than mutating the original message.
faye · Apr 27, 2016 · 6a92cac · 6a92cac
1 parent 2be8295
commit 6a92cac
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/websocket/driver/hybi.js b/lib/websocket/driver/hybi.js
@@ -264,11 +264,11 @@ var instance = {
       buffer.writeUInt32BE(length % 0x100000000, 6);
     }
 
+    frame.payload.copy(buffer, offset);
+
     if (frame.masked) {
       frame.maskingKey.copy(buffer, header);
-      Hybi.mask(frame.payload, frame.maskingKey).copy(buffer, offset);
+      Hybi.mask(buffer, frame.maskingKey, offset);
-    } else {
-      frame.payload.copy(buffer, offset);
     }
 
     this._write(buffer);