Flag files that modify string literals #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in an environment that freezes string literals by default,
hybi.rb
raises exceptions as it modifies theformat = 'C2'
string (line 224).Adding the magic comment supports this use case without modifying behavior for anyone else. I added it to one spec too, so that running specs this way (
RUBYOPT="--enable=frozen-string-literal" rspec
) keeps them all passing.