Sound Null Safety #164
Merged
Sound Null Safety #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diegogarciar Also if you can also update flutter_parsed_text to v2.1.0 that also support null safety that would be great. |
diegogarciar
commented
Mar 6, 2021
fayeed
reviewed
Mar 8, 2021
If it's required then the variable can't be non-nullable
|
@diegogarciar Thanks for the PR |
|
@diegogarciar Updated the package to |
AramSemerjyan
pushed a commit
to STDevTM/dash_chat
that referenced
this pull request
May 4, 2021
This reverts commit 414a213.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I wanted to contribute by adding null safety to this package, I used mainly the migration tool and also removed added some
requiredfor fields that were always initialized as non-null. I also optimized some checks to use optional chaining instead of null checking.