fix: table-component #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faran4engg
reviewed
Oct 12, 2020
src/components/index.ts
Outdated
| //Form | ||
| export { default as Input } from './Form/Input/Input'; | ||
| export { default as TextArea } from './Form/TextArea/TextArea'; | ||
| export { default as CheckBox } from './Form/CheckBox/CheckBox'; | ||
| export { default as Select } from './Form/Select/Select'; | ||
| export { default as Radio } from './Form/Radio/Radio'; | ||
| export { default as LoadingWrapper } from './Form/LoadingWrapper/LoadingWrapper'; |
There was a problem hiding this comment.
bhai banda use kaise karega agar apun export nhi marenge to
There was a problem hiding this comment.
but what is this loading wrapper for ? I dont see its usage in Table !
There was a problem hiding this comment.
wo export krna bhul gaye the
faran4engg
reviewed
Oct 12, 2020
| import React from 'react'; | ||
| import { TableCellProps } from './types'; | ||
|
|
||
| const TableCell: React.SFC<TableCellProps> = ({ children }) => { |
faran4engg
reviewed
Oct 12, 2020
| import React from 'react'; | ||
| import { TableHeadingProps } from './types'; | ||
|
|
||
| const TableHeading: React.SFC<TableHeadingProps> = ({ children }) => { |
There was a problem hiding this comment.
I still see const TableHeading: React.SFC
faran4engg
reviewed
Oct 12, 2020
| import React from 'react'; | ||
| import { TableRowProps } from './types'; | ||
|
|
||
| const TableRow: React.SFC<TableRowProps> = ({ children }) => { |
faran4engg
reviewed
Oct 12, 2020
| import React from 'react'; | ||
| import { TbodyProps } from './types'; | ||
|
|
||
| const Tbody: React.SFC<TbodyProps> = ({ children }) => { |
faran4engg
reviewed
Oct 12, 2020
| import React from 'react'; | ||
| import { TheadProps } from './types'; | ||
|
|
||
| const Thead: React.SFC<TheadProps> = ({ children }) => { |
faran4engg
reviewed
Oct 12, 2020
| import React from 'react'; | ||
| import { TfootProps } from './types'; | ||
|
|
||
| const Tfoot: React.SFC<TfootProps> = ({ children }) => { |
faran4engg
reviewed
Oct 12, 2020
src/components/index.ts
Outdated
|
|
||
| //Table | ||
| export { default as Table } from './Elements/Table/Table'; | ||
| export { default as Thead } from './Elements/Table/Thead'; |
There was a problem hiding this comment.
I would name it as THead
faran4engg
reviewed
Oct 12, 2020
src/components/index.ts
Outdated
| export { default as Table } from './Elements/Table/Table'; | ||
| export { default as Thead } from './Elements/Table/Thead'; | ||
| export { default as Tfoot } from './Elements/Table/Tfoot'; | ||
| export { default as Tbody } from './Elements/Table/Tbody'; |
There was a problem hiding this comment.
I would name them as TFoot and TBody
The build is failing because you did not update filenames @fayez-baig |
faran4engg
approved these changes
Oct 12, 2020
|
🎉 This PR is included in version 1.0.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.