Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker badges to use lower case #32

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Conversation

powerman
Copy link
Contributor

@powerman powerman commented Apr 4, 2018

I've noticed an issue with just added docker badges: while repo name on github can use upper case letters (like yours, mine, and I suppose it's usual case for Perl modules on github) related repo on hub.docker.com will be always lower case. Even if I try to create docker repo using upper case it converts it to lower case and url with original upper case name returns 404. Same happens for user name - I've just tried to create account with upper case on docker hub to test this.

Not sure is this issue also affect other badges, so I've fixed only docker's.

@fayland fayland merged commit 0185cdf into fayland:master Apr 4, 2018
@fayland
Copy link
Owner

fayland commented Apr 4, 2018

cool. many thanks!

@coveralls
Copy link

coveralls commented Apr 4, 2018

Coverage Status

Coverage increased (+0.5%) to 98.446% when pulling f9e72a9 on powerman:docker into f7096d6 on fayland:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants