Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow upload on upgraded hackage #472

Merged
merged 28 commits into from
Jan 10, 2021
Merged

Conversation

swamp-agr
Copy link
Contributor

@swamp-agr swamp-agr commented Jan 8, 2021

Opening separate PR, since there is an error while uploading fay on hackage:

Uploading $HOME/projects/fay/dist-newstyle/sdist/fay-0.24.1.1.tar.gz...
Error uploading
$HOME/projects/fay/dist-newstyle/sdist/fay-0.24.1.1.tar.gz: http code 400
Error: Invalid package

'cabal-version' must be at least 1.10

Bumping to 1.10 did not helped.

@swamp-agr
Copy link
Contributor Author

It seems that Travis CI is setting up cabal-install version 2.0.
It's not aligned properly with spec-version 3.0.
Trying adopt haskell-ci tool with current fay.cabal.

@swamp-agr
Copy link
Contributor Author

Right now fay-tests cannot recognize installed ghc on CI server:

$ ${CABAL} v2-exec fay-tests -- --num-threads=4 -random 20
cabal: The program 'ghc' version >=7.0.1 is required but it could not be found.

The command "${CABAL} v2-exec fay-tests -- --num-threads=4 -random 20" exited with 1.

@swamp-agr
Copy link
Contributor Author

As mentioned here (haskell/cabal#6722), autogen-modules section could be skipped for executables.

@swamp-agr
Copy link
Contributor Author

Now I am able to reproduce CI behaviour locally for 8.8 branch (similar to #470).

@swamp-agr
Copy link
Contributor Author

Next steps:

  • resolve test errors one-by-one.
ghc-pkg: cannot find package fay-base

proposed solution: extend whatAGreatFramework with following logic:

  • ✅ gather global, local package-db.
  • ⚙️ if existed, add package-db from command-line arguments.
  • ⚙️ ensure that parameter values are unique.

@swamp-agr
Copy link
Contributor Author

After investigating, it was decided to postpone v2 handling as it is harder than I initially thought.
For now, downgrading Travis CI from v2 to v1 resolves ghc-pkg error: fay-base is missing.

@swamp-agr swamp-agr merged commit 9bf19d7 into master Jan 10, 2021
@swamp-agr swamp-agr deleted the allow-upload-on-upgraded-hackage branch January 10, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant