added missing parameter to documentation #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massimilianobraglia
requested changes
Oct 12, 2019
There was a problem hiding this comment.
Hey there @enrike1983!
Thank you for your contribution. I just left a little comment to explain better the parameters of that function.
README.md
Outdated
| @@ -62,11 +62,12 @@ To create a `MailingList` you can follow this example. Please, refer to the [Mai | |||
| use Fazland\MailUpRestClient\MailingList; | |||
|
|
|||
| $email = "owner_of_the_list@email.com"; | |||
| $name = "owner_name"; | |||
There was a problem hiding this comment.
It's not the owner name but the list name :)
Just a little clarification for the docs.
There was a problem hiding this comment.
Ok looks good, thank you
There was a problem hiding this comment.
Can you adjust the code?
|
@enrike1983 why did you close this one? |
|
Thank you, @enrike1983. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.