fix(general): Fix descendant cache typo

fb55 · Oct 2, 2020 · 0c0a8ff · 0c0a8ff
1 parent b8ae895
commit 0c0a8ff
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/general.ts b/src/general.ts
@@ -70,7 +70,7 @@ export function compileGeneralSelector<Node, ElementNode extends Node>(
                 let current: ElementNode | null = elem;
 
                 while ((current = adapter.getParent(current))) {
-                    if (!isFalseCache.has(elem)) {
+                    if (!isFalseCache.has(current)) {
                         if (next(current)) return true;
                         isFalseCache.add(current);
                     }

diff --git a/test/sizzle.ts b/test/sizzle.ts
@@ -1727,4 +1727,13 @@ describe("Sizzle", () => {
             document.getElementById("foo")
         );
     });
+
+    it("more specific selector should find less elements", () => {
+        // Same selector, but with an attribute filter added
+        expect(
+            CSSselect.selectAll("#qunit-fixture div div", document).length
+        ).toBeGreaterThanOrEqual(
+            CSSselect.selectAll("#qunit-fixture div div[id]", document).length
+        );
+    });
 });