Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entities.decode(''', 2) decodes *twice*. #8

Closed
cscott opened this issue Apr 18, 2013 · 0 comments
Closed

entities.decode(''', 2) decodes *twice*. #8

cscott opened this issue Apr 18, 2013 · 0 comments

Comments

@cscott
Copy link
Contributor

cscott commented Apr 18, 2013

entities.decode(''', 2) returns '\''. That's just wrong. It should return '''.
cscott added a commit to cscott/node-entities that referenced this issue Apr 18, 2013
@cscott
Add test suite.
6ad621f 
This also documents gh issue fb55#8 with a failing test.
@cscott cscott mentioned this issue Apr 18, 2013
Merged
cscott added a commit to cscott/node-entities that referenced this issue Apr 18, 2013
@cscott
Only invoke String.replace() once during decode. (fixes gh fb55#8)
ab41f93
fb55 added a commit that referenced this issue Apr 19, 2013
@fb55
Merge pull request #9 from cscott/test-suite
9a7491d 
Add test suite; fix gh #8 (double decode)
@fb55 fb55 closed this as completed Apr 23, 2013
@fb55 fb55 mentioned this issue Jul 30, 2013
Closed
fb55 pushed a commit that referenced this issue Oct 21, 2018
@cscott
Add test suite.
de655d5 
This also documents gh issue #8 with a failing test.
fb55 pushed a commit that referenced this issue Oct 21, 2018
@cscott
Only invoke String.replace() once during decode. (fixes gh #8)
e6066b6
fb55 added a commit that referenced this issue Oct 21, 2018
@fb55
Merge pull request #9 from cscott/test-suite
7d5074a 
Add test suite; fix gh #8 (double decode)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cscott @fb55