Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add media content parsing to FeedHandler #560

Merged
merged 4 commits into from
Sep 13, 2020
Merged

Add media content parsing to FeedHandler #560

merged 4 commits into from
Sep 13, 2020

Conversation

gcandal
Copy link
Contributor

@gcandal gcandal commented Sep 11, 2020

@coveralls
Copy link

coveralls commented Sep 11, 2020 •
edited

Coverage Status

Coverage increased (+0.02%) to 98.593% when pulling 823da1a on gcandal:media-feed-handler into 5f25363 on fb55:master.

fb55
fb55 reviewed Sep 11, 2020
View reviewed changes
Copy link
Owner

@fb55 fb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One issue, and it would be great if you could modify one of the existing feeds to include a media element (to make sure this is tested).

src/FeedHandler.ts Outdated Show resolved Hide resolved
@gcandal
Copy link
Contributor Author

gcandal commented Sep 12, 2020

Looks great! One issue, and it would be great if you could modify one of the existing feeds to include a media element (to make sure this is tested).

Done 👍 . May I ask you if got any plans regarding the release schedule, when is the next one going to take place, etc?

@gcandal gcandal requested a review from fb55 September 12, 2020 09:59
@fb55 fb55 merged commit a85e4e0 into fb55:master Sep 13, 2020
@fb55
Copy link
Owner

fb55 commented Sep 13, 2020

Updated the code to only add elements that actually exist (in c708f55). This deals with a bunch of NaNs that were present in the output before.

I should be able to put out a new release in the next few days.

@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fb55 fb55 Awaiting requested review from fb55

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gcandal @coveralls @fb55