Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False discovery rate #21

Open
Yefeng0920 opened this issue Mar 2, 2024 · 1 comment
Open

False discovery rate #21

Yefeng0920 opened this issue Mar 2, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@Yefeng0920
Copy link

Hi zcurve developer

I am curious about how to get the false discovery rate from zcurve package, as described in this paper:
Schimmack U, Bartoš F (2023) Estimating the false discovery risk of (randomized) clinical trials in medical journals based on published p-values. PLOS ONE 18(8): e0290084. https://doi.org/10.1371/journal.pone.0290084

I could find this estimate. See below reproducible example:
set.seed(666)
library(zcurve)
fit <- zcurve(OSC.z)
summary(fit)

BTW, would you like to show how to use swfdr package to compute the false positive rate using the dataset OSC.z? I want to compare the two packages.

Best,
Yefeng

@FBartos FBartos added the documentation Improvements or additions to documentation label Mar 4, 2024
@FBartos
Copy link
Owner

FBartos commented Mar 4, 2024

Hi Yefeng,

You can obtain the false discovery risk (Soric's FDR) estimate by adding all = TRUE argument to the summary function.
(I recognize that this should be a bit better documented)

> library(zcurve)
> fit <- zcurve(OSC.z)
> summary(fit, all = TRUE)
Call:
zcurve(z = OSC.z)

model: EM via EM

              Estimate  l.CI   u.CI
ERR              0.615 0.458  0.746
EDR              0.383 0.072  0.691
Soric FDR        0.085 0.023  0.675
File Drawer R    1.608 0.446 12.826
Expected N         222   123   1175
Missing N          132    33   1085

Model converged in 53 + 62 iterations
Fitted using 73 z-values. 90 supplied, 85 significant (ODR = 0.94, 95% CI [0.87, 0.98]).
Q = -60.61, 95% CI[-71.04, -47.86]

Thanks for the suggestion for a comparison with the swfdr---it would make for a very nice vignette! I will keep it in mind when having some free time over the weekends :)

Cheers,
Frantisek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants