Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Error class in nvidia_smi.py #5

Closed
thupalo opened this issue Nov 15, 2017 · 1 comment
Closed

[bug] Error class in nvidia_smi.py #5

thupalo opened this issue Nov 15, 2017 · 1 comment

Comments

@thupalo
Copy link

thupalo commented Nov 15, 2017

Great code.
Could you please check handleError call in nvidia_smi.py line 184.
I'm suggesting replace
val = handleError(NVML_ERROR_NOT_SUPPORTED);
by
val = handleError(NVMLError(NVML_ERROR_NOT_SUPPORTED));
because it gives me error while comparing value attribute in error handler.

BR/thupalo
fbcotter added a commit that referenced this issue Nov 16, 2017
@fbcotter
Fixed bug from issue #5
cd5cd8d 
Added call to NVMLError class constructor. Have no way to test this but
it looks good.
@fbcotter
Copy link
Owner

Done.

This is in the part of the code written by NVIDIA, which is a horrendous mess, so I am unable to test changes here, but your suggestion looked right.

fbcotter added a commit that referenced this issue May 17, 2018
@fbcotter
Merge remote-tracking branch 'origin/master'
310ff88 
* origin/master:
  Fixed bug from issue #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fbcotter @thupalo