Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting empty component names clears component ids #152

Closed
jonrkarr opened this issue Sep 4, 2021 · 3 comments
Closed

Setting empty component names clears component ids #152

jonrkarr opened this issue Sep 4, 2021 · 3 comments

Comments

@jonrkarr
Copy link
Contributor

jonrkarr commented Sep 4, 2021

Example:

import libsedml

# create data set
data_set = libsedml.SedDataSet()

# set id
assert data_set.setId('obj') == 0

# check id set
assert data_set.getId() == 'obj'

# set empty name
assert data_set.setName('') == 0

# id is no longer set!
assert data_set.getId() == 'obj'

Environment:

  • libsedml: 2.0.25
  • Python: 3.9.5
  • OS: Ubuntu
@luciansmith
Copy link
Collaborator

Whoops! Sorry about that--simple fix, now with pull request.

@jonrkarr
Copy link
Contributor Author

jonrkarr commented Sep 5, 2021

Thanks!

fbergmann added a commit that referenced this issue Sep 7, 2021
@fbergmann
Copy link
Owner

made a new release with the fix, will upload python binaries over the day as they get ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants