Create $(datadir) before attempting to install timezeal.* to it. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative would be to fix #5 while keeping this problem in mind instead. |
|
I have just pushed a fix to this issue, but keeping the directories before files order of the other entries. |
|
Nice, thanks :-)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
install-bintarget is run before theinstall-datatarget duringinstall, it can happen that$(datadir)does not yet exist while trying to installzsealto$(datadir)/timeseal.$(osname).This can lead to build failures, for example as reported for the Archlinux AUR build process (see https://aur.archlinux.org/packages/eboard/). I suggested a workaround for them to avoid the problem, but it would be much nicer to fix this right here, so I hope you will merge this tiny change :-).