Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

National participation endpoint #415

Merged
merged 2 commits into from
Mar 10, 2017
Merged

National participation endpoint #415

merged 2 commits into from
Mar 10, 2017

Conversation

harrisj
Copy link
Contributor

@harrisj harrisj commented Mar 10, 2017

This pull request fixes two things:

  1. Changes total populations for states and counties to be a sum of agency population instead of county population.
  2. Adds state_name and county_name to the cde_participation_rate table so I don't need to join because SqlAlchemy is terrible.

This adds a new endpoint at /participation/national

@harrisj
Copy link
Contributor Author

harrisj commented Mar 10, 2017

Fixes #412
Fixes 18F/crime-data-explorer#312

@harrisj harrisj force-pushed the national-participation-endpoint branch from 9e16a1f to 6c09942 Compare March 10, 2017 02:39
@cacraig
Copy link
Contributor

cacraig commented Mar 10, 2017

Looks good - Merging because the DB changes are live.

@cacraig cacraig merged commit 281f19f into master Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@harrisj @cacraig