Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing out validation of the API with Swagger #435

Merged
merged 12 commits into from
Mar 27, 2017
Merged

Conversation

harrisj
Copy link
Contributor

@harrisj harrisj commented Mar 17, 2017

Look at me, building up my swagger.json the proper way and using it to validate API requests and responses.

@harrisj
Copy link
Contributor Author

harrisj commented Mar 17, 2017

The eventual endgame here would be to remove flask-apispec and apispec and treat the swagger.json (or YAML if we'd prefer to use that) as the contract of how the API should respond. We could continue to keep the Swagger-UI here in this project or move it to the explorer.

Jacob Harris added 8 commits March 23, 2017 09:59
This is far from done. Right now it has some FEC-specific
branding. Also, it doesn't seem to be displaying all responses for
endpoints (only the default ones). But it's a start in potentially
removing the flask-apispec and apispec modules.
Still experimenting with how to tag things and describe documentation.
@harrisj harrisj changed the title WIP: Testing out validation of the API with Swagger Testing out validation of the API with Swagger Mar 27, 2017
@harrisj
Copy link
Contributor Author

harrisj commented Mar 27, 2017

Okay, this is good to go now for review. 75 FILES CHANGED later...

@cacraig
Copy link
Contributor

cacraig commented Mar 27, 2017

Phew! This looks good to go. Going to merge this! Thanks!

@cacraig cacraig merged commit 101c8c0 into master Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants