Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to how we build participation tables #475

Merged
merged 4 commits into from
May 5, 2017
Merged

Conversation

harrisj
Copy link
Contributor

@harrisj harrisj commented Apr 26, 2017

No description provided.

@harrisj harrisj changed the title WIP: Fix to how we build participation tables Fix to how we build participation tables Apr 28, 2017
@harrisj
Copy link
Contributor Author

harrisj commented Apr 28, 2017

So, this is better for participation and the DB tables are already in production, but it makes some changes to existing API endpoints that would need to be made as well. Sorry, but I figure it's best to break things now:

/geo/states/<state_id>

  • rename reporting_agencies to participating_agencies
  • rename covered_population to participating_population

State participation endpoints:

  • rename reporting_agencies to participating_agencies
  • rename covered_population to participating_population
  • rename reported to participated
  • rename reporting_rate to participation_rate
  • rename nibrs_reporting_agencies to nibrs_participating_agencies
  • rename nibrs_reporting_rate to nibrs_participation_rate

cc @jeremiak

@harrisj
Copy link
Contributor Author

harrisj commented May 1, 2017

Fixes #472

@cacraig
Copy link
Contributor

cacraig commented May 5, 2017

Looks fine to me. Merging!

@cacraig cacraig merged commit d19f8f4 into master May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants