Nibrs agency api #521
Merged
Nibrs agency api #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2017 16:03
|
@harrisj - I can't seem to tag you as the reviewer on this for some reason. When you get a chance, can you take a look at this? Thanks! |
harrisj
approved these changes
May 22, 2017
| @@ -1015,7 +1015,7 @@ def get_field_table(self, field): | |||
| return ('ref_race','race_code') | |||
|
|
|||
| if field in ['sex_code']: | |||
| return ('nibrs_victim_denorm_2012','sex_code') | |||
| return ('victim_counts_2012','sex_code') | |||
There was a problem hiding this comment.
Is there a reason why this is pegged to a single year of materialized data?
| @@ -1083,9 +1083,9 @@ def base_query(self, field): | |||
| join_table,join_field = self.get_field_table(field) | |||
| if join_field: | |||
| if self.year: | |||
| query_gap_fill = ' RIGHT JOIN (SELECT DISTINCT ' + join_table + '.' + join_field + ' AS :field, c.year from ' + join_table + ' RIGHT JOIN (SELECT year::text, :view_name.:field from :view_name ' + inner_where_query + ' GROUP BY year,:view_name.:field ORDER BY year DESC) c ON (c.:field = ' + join_table +'.' + join_field + ')) b ON (a.:field = b.:field)' | |||
| query_gap_fill = ' RIGHT JOIN (SELECT DISTINCT ' + join_table + '.' + join_field + ' AS :field, c.year from ' + join_table + ' CROSS JOIN (SELECT year::text from nibrs_years WHERE year::int = :year) c) b ON (a.:field = b.:field)' | |||
There was a problem hiding this comment.
Sing to the tune of Trogdor: "CROSS JOIN! CROSS JOIN! Combinating the tables! Combinating the fields!"
Seriously, this is interesting, but I think I would like if you could use SqlAlchemy's interpolation (I think there are some cases where you can say "Unescape this field") since I worry this would trip off SQL injection alerts?
harrisj
added
workflow: in-progress
and removed
workflow: in-progress
in progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some major performance issues in production with the NIBRS API's. The indexes and such are already live.