Remove some remaining authentication remnants #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When they first created this app, they used a Flask skeleton app which had support for user login and the like. This API has no user logins (only a single shared token used by the API frontend proxy), so I removed most of that in PR #121 But there were some references to setting a SECRET in the docs and in the environment variable, so need to clean those up. Also, removing http auth which was only there for protecting the Swagger.json page before we started ATO process.
|
@harrisj - The tests seem to have failed on this one. E RuntimeError: The Flask-DebugToolbar requires the 'SECRET_KEY' config var to be set |
added 2 commits
June 29, 2017 11:45
Also getting rid of an unused Swagger API layout
|
Yep, I decided to go ahead and yank out some of the debugging bits (like the Flask Toolbar) and the asset pipelines and templating that were being used only by our error pages. |
|
Tests now pass. This is good for review again @cacraig |
|
Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When they first created this app, they used a Flask skeleton app which had support for user login and the like. This API has no user logins (only a single shared token used by the API frontend proxy), so I removed most of that in PR #121
But there were some references to setting a SECRET in the docs and in the environment variable, so need to clean those up.
Also, removing http_auth which was only there for protecting the Swagger.json page before we started ATO process.