Refactor sharing tag component #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let's sync on this on Monday -- there are some slightly tricky things around this that we should talk through (i.e., when agencyReceived action is dispatched, that sets agencies.loading state to false but then we rely on that loading variable to signal when all of the agency data is loaded -- i think we may just need to add another loading field to the agencies object) |
jeremiak
force-pushed
the
jk-sharing-content
branch
2 times, most recently
from
385fa86
to
5c3dba7
Compare
added 8 commits
July 19, 2017 15:03
Also make the displayed text reflect the URL values
Update a few primary county calculations as well as some coordinates
No router and no connection, just defaults and strings that can be passed in
Use a small mapping of just ORIs to agency names (as little information as possible so as to bloat the compiled server.js as little as possible) so that sharing tags for agency views will have the name at the time the crawler scrapes the page the information is there
Using actions on the server to update the store's state is great, but it sometimes requires two to make sure that the loading flag is flipped to true for the initial state
jeremiak
force-pushed
the
jk-sharing-content
branch
from
5c3dba7
to
0901a0c
Compare
jeremiak
force-pushed
the
jk-sharing-content
branch
from
0901a0c
to
e7b0ed3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #576