Fix to Filter not being proprely handled when naviagating back to Home Page #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwentz
added
workflow: in-progress
workflow: review
and removed
workflow: in-progress
labels
|
These are insanely particular code checks . It can still be merged. |
added 2 commits
August 22, 2017 14:07
jeremiak
force-pushed
the
jw-summary-range-fix
branch
from
6af0160
to
3980964
Compare
jeremiak
approved these changes
Aug 22, 2017
| if (f.crime && !isValidCrime(f.crime)) delete f.crime | ||
| if (f.place && !lookupUsa(f.place, f.placeType)) delete f.place | ||
|
|
||
| const f = filterValidator({ ...filters }) |
There was a problem hiding this comment.
Let's combine this with the line below so that we don't have to declare the variable
| @@ -1,15 +1,9 @@ | |||
| import { FILTER_RESET, FILTERS_UPDATE } from './constants' | |||
| import offenses from '../util/offenses' | |||
| import lookupUsa from '../util/usa' | |||
| import filterValidator from '../util/filter' | |||
There was a problem hiding this comment.
Love pulling this out into a util
| @@ -0,0 +1,63 @@ | |||
| /* eslint no-undef: 0 */ | |||
There was a problem hiding this comment.
I added a test file for the new util, FYI
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.