Multihub #5
Merged
Multihub #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason: avoid being too generic and reuse the same field that webhook configuration section
reason: clearer
reason: be consistency with other config
reason: better readability and we don't care of ultra performance for this piece of code
fblackburn1
approved these changes
Feb 29, 2020
|
Looks good! I like the addition of the validator for the webhook path!
…On Sat, Feb 29, 2020 at 11:38 PM Francois Blackburn < ***@***.***> wrote:
***@***.**** approved this pull request.
Everything seems good 🎉
Can you validate one more time before I merge it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5?email_source=notifications&email_token=AF5CCQMJGOPIAYN7XATZWG3RFGG5HA5CNFSM4K2XSYP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXOUSVY#pullrequestreview-366823767>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF5CCQO2YZXNBPVCFYLCOSLRFGG5HANCNFSM4K2XSYPQ>
.
|
reason: is reserved to the admin UI
reason: on migration, the webhookPath will be undefined which cause the default value to be "/_" which is wrong, because the server use the value "/hubitat/webhook" when undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resending the multi hub PR as I closed the original one. This PR includes all changes needed to support multiple Hubitats.