Shared assemblies #328
Merged
Shared assemblies #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature: allowing user provided --assembly and --preset
fboucquez
force-pushed
the
shared_assemblies
branch
3 times, most recently
from
e1dbf1a
to
f6e38f7
Compare
fboucquez
force-pushed
the
shared_assemblies
branch
2 times, most recently
from
d810e8b
to
441eac1
Compare
fix: added new lines when generating unit test reports fix: improved README.md
fboucquez
force-pushed
the
shared_assemblies
branch
from
441eac1
to
4297a97
Compare
|
@Jaguar0625 , could you review this one when you have the time? |
Jaguar0625
suggested changes
Nov 26, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Jaguar0625
approved these changes
Nov 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr moves all the network's assemblies to a top-level commonplace.
NOTE
In PR https://github.com/symbol/symbol-bootstrap/pull/331 the user can provide its own network.yml or assembly.yml (advance feature)
Examples:
symbol-bootstrap start --preset a-future-testnet-network.yml --assembly dualsymbol-bootstrap start --preset garush-network.yml --assembly my-custom-assembly.yml