Nemesis configuration improvements #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfaultxavi
suggested changes
Nov 29, 2021
fboucquez
force-pushed
the
nemesis_configuration_improvements
branch
from
c1f1e34
to
4c20a1c
Compare
fboucquez
changed the title
fboucquez
force-pushed
the
nemesis_configuration_improvements
branch
from
4c20a1c
to
b78a287
Compare
fboucquez
force-pushed
the
nemesis_configuration_improvements
branch
from
b78a287
to
c37a67e
Compare
Jaguar0625
reviewed
Dec 6, 2021
fboucquez
force-pushed
the
nemesis_configuration_improvements
branch
from
c37a67e
to
44a137e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Jaguar0625
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Fixed config/start --preset and --assembly options (it was the other way around)Already merged in another pr2. Removed unnecessary currency names from custom preset. It can be provided and resolved from the
nemesis.mosaicsfield3. Moved "opt-in" addresses/balances from
nemesistonemesis.mosiac. User (or symbol-network) can provide balances for multiple mosaics, although most of the time there is only one nemesis mosaic (like xym).4. Allow a node to be excluded from nemesis (no balance or linked transactions).
5. Allow users to provide node nemesis balance. If the balance is calculated, it will be less than
maxHarvesterBalance6. Better nemesis supply distribution and exception handling. Added unit tests.
If this is too much I can split further. Note I would be creating a new PR where the genesis related configuration is moved to their own class/service