[bootstrap] task: add option to configure node metadata #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wayonb
previously approved these changes
May 8, 2023
| @@ -223,6 +223,8 @@ restProtocol: HTTP | |||
| restSSLPath: '/symbol-workdir' | |||
| restSSLKeyFileName: 'restSSL.key' | |||
| restSSLCertificateFileName: 'restSSL.crt' | |||
| restNodeMetadata: | |||
| _info: "Node metadata" | |||
There was a problem hiding this comment.
Do you know what's the default use case for this endpoint?
It would be nice to autofill the default values.
There was a problem hiding this comment.
For example, at this moment, additional information about the node listed in https://symbol-tools.com/symbolTools/view/tool/nodeList.html are added manually via an additional configuration file (https://symbol-tools.com/nodeSetting.json generated here https://symbol-tools.com/symbolTools/view/tool/nodeAdminManual.html). This is possible if you host the node, but Bootstrap will now support it.
I don't know what default keys/values should be set. Default values may be wrongly read as set by the operator 🤔
cryptoBeliever
force-pushed
the
add_metadata_configuration
branch
from
5b1c699
to
434177a
Compare
Wayonb
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the issue?
Newly added endpoint /node/metadata in REST returns meta-information about the node. Bootstrap doesn't allow users to define custom values for this endpoint.
What's the solution?
Add the possibility to define node meta-information via custom preset. This can be done by: