Add the option to fix the random seed #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
changed the title
RemiLehe
commented
Jul 7, 2022
tests/test_compton.py
Outdated
| @@ -87,7 +87,7 @@ def run_simulation( gamma_boost, show ): | |||
| zmax, zmin = boost.copropag_length( [zmax_lab, zmin_lab], beta_object=1. ) | |||
| sim = Simulation( Nz, zmax, Nr, rmax, Nm, dt, | |||
| dens_func=None, zmin=zmin, boundaries={'z':'periodic', 'r':'reflective'}, | |||
| use_cuda=use_cuda ) | |||
| use_cuda=use_cuda, random_seed=0 ) | |||
There was a problem hiding this comment.
This ensures that the new feature is being used in at least one automated test.
|
Let us actually create a separate free function, that can be called at the beginning of the script, and include it in some of the examples. |
RemiLehe
commented
Jul 7, 2023
| @@ -75,7 +75,7 @@ | |||
| # | |||
| # This is also used if you do content translation via gettext catalogs. | |||
| # Usually you set "language" from the command line for these cases. | |||
| language = None | |||
| language = 'en' | |||
There was a problem hiding this comment.
This is unrelated to the rest of the PR, but I took advantage of this PR to quickly clean up conf.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #48.
Note that this will affect the following parts of FBPIC which rely on random numbers:
numpy.random(on GPU and CPU)numpy.random(on GPU and CPU)numpy.random(CPU) orcupy.random(GPU)numpy.random. However, I am not sure whether the current PR will set the seed for the CPU part of the code (https://github.com/fbpic/fbpic/blob/dev/fbpic/particles/elementary_process/compton/numba_methods.py#L192)