Initial integration with --roboflow_upload

[SkalskiP]

Hi, @fcakyon 👋🏻!

I spent some time today building the initial version of --roboflow_upload flag. I have a small problem, however.

I'm getting: FileNotFoundError: [Errno 2] No such file or directory: 'runs/train/exp/results.png'. Is there any reason why you decided not to save results.png chart?

[fcakyon]

it should not download into pip package directory

[SkalskiP]

The current version, with changes I made last time, is downloading to the same directory as the current version. Where would you like me to download it?

[fcakyon]

Yes, you are right. I missed it the last time. I prefer to save that dataset to the current working directory.

[fcakyon]

it should not download into pip package directory

[fcakyon]

it should not download into pip package directory

[fcakyon]

Hi, @fcakyon 👋🏻!

I spent some time today building the initial version of --roboflow_upload flag. I have a small problem, however.

I'm getting: FileNotFoundError: [Errno 2] No such file or directory: 'runs/train/exp/results.png'. Is there any reason why you decided not to save results.png chart?

Actually it should save that file. I did not change anything to skip that file. Is the latest version in original repo saving it?

[SkalskiP]

Is the latest version in original repo saving it?

Do you mean YOLOv5? Yes.

[SkalskiP]

But you save the result.html file. Is that on purpose?

[fcakyon]

Yes we find it use

Is the latest version in original repo saving it?

Do you mean YOLOv5? Yes.

Then there must be a bug in this repo. I have to check the related line 👍

[fcakyon]

But you save the result.html file. Is that on purpose?

Yes we find it very useful in experiment tracking logs.

[fcakyon]

Same line is present in yolov5-pip

ultralytics/yolov5: https://github.com/ultralytics/yolov5/blob/cec1b9bc923cdd235baa3b9b5c80e3700bc9b1dc/utils/loggers/__init__.py#L326-L271

fcakyon/yolov5-pip:

yolov5-pip/yolov5/utils/loggers/__init__.py

Lines 326 to 327 in a05ce22

	if self.plots:
	plot_results(file=self.save_dir / 'results.csv') # save results.png

[SkalskiP]

@fcakyon it is about results.png, not results.csv. The .csv file was saved properly.

[SkalskiP]

Yes we find it very useful in experiment tracking logs.

So it is an additional file, not instead of result.png?

[fcakyon]

Yes we find it very useful in experiment tracking logs.

So it is an additional file, not instead of result.png?

Yes it is an addition to results.png.

[fcakyon]

@fcakyon it is about results.png, not results.csv. The .csv file was saved properly.

Check the comment in the line I provided. plot_results function reads values from results.csv and then exports the results as results.png.

yolov5-pip/yolov5/utils/plots.py

Lines 488 to 511 in a05ce22

	def plot_results(file='path/to/results.csv', dir=''):
	# Plot training results.csv. Usage: from yolov5.utils.plots import *; plot_results('path/to/results.csv')
	save_dir = Path(file).parent if file else Path(dir)
	fig, ax = plt.subplots(2, 5, figsize=(12, 6), tight_layout=True)
	ax = ax.ravel()
	files = list(save_dir.glob('results*.csv'))
	assert len(files), f'No results.csv files found in {save_dir.resolve()}, nothing to plot.'
	for f in files:
	try:
	data = pd.read_csv(f)
	s = [x.strip() for x in data.columns]
	x = data.values[:, 0]
	for i, j in enumerate([1, 2, 3, 4, 5, 8, 9, 10, 6, 7]):
	y = data.values[:, j].astype('float')
	# y[y == 0] = np.nan # don't show zero values
	ax[i].plot(x, y, marker='.', label=f.stem, linewidth=2, markersize=8)
	ax[i].set_title(s[j], fontsize=12)
	# if j in [8, 9, 10]: # share train and val loss y axes
	# ax[i].get_shared_y_axes().join(ax[i], ax[i - 5])
	except Exception as e:
	LOGGER.info(f'Warning: Plotting error for {f}: {e}')
	ax[1].legend()
	fig.savefig(save_dir / 'results.png', dpi=200)
	plt.close()

[fcakyon]

@SkalskiP is there anything I can do for this PR?

I will be very busy with a conference submission deadline till next Friday but can help you with this PR after then 👍

[SkalskiP]

@fcakyon, no worries. I think it is mostly on me to figure it out. As a matter of fact, I'm working on it now.

[SkalskiP]

@fcakyon calling plot_results as you suggested solved my problem. Upload works. Tests fail as I don't have access to your secret Roboflow key. When you run them, they should pass. 🟢 🧪 🤞🏻

[SkalskiP]

@fcakyon are you back from the conference already?

[fcakyon]

Yes, I am back home, I will look into this as soon as possible. Sorry for the delay.

[SkalskiP]

@fcakyon, no worries :)

[fcakyon]

@SkalskiP it passed the tests. Thank you for the PR!

[SkalskiP]

@fcakyon, is it already released?

[SkalskiP]

@fcakyon okay, I checked. It looks like it is not part of 7.0.10 release. Any idea when you plan to release roboflow_upload?

[fcakyon]

@SkalskiP just released: https://github.com/fcakyon/yolov5-pip/releases/tag/7.0.11

[SkalskiP]

@fcakyon let me test that

[SkalskiP]

@fcakyon works! 🎉

[fcakyon]

@fcakyon works! 🎉

Awesome news!