Ebert complains on test

fcevado · Apr 23, 2017 · 91c50cd · 91c50cd
1 parent 1821406
commit 91c50cd
Show file tree

Hide file tree

Showing 3 changed files with 66 additions and 51 deletions.
diff --git a/.ebert.yml b/.ebert.yml
@@ -0,0 +1,19 @@
+# This configuration was used Ebert to review the fcevado/phone repository
+# on 135f7621e5521278abc6862b4ed989b88aa6b2c4.
+# You can make this the default configuration for future reviews by moving this
+# file to your repository as `.ebert.yml` and pushing it to GitHub, and tweak
+# it as you wish - To know more on how to change this file to better review your
+# repository you can go to https://ebertapp.io/docs/config and see the configuration
+# details.
+---
+styleguide: plataformatec/linters
+engines:
+  credo:
+    enabled: true
+  fixme:
+    enabled: true
+  remark-lint:
+    enabled: true
+exclude_paths:
+- test/**/*
+
diff --git a/test/phone/countries_test.exs b/test/phone/countries_test.exs
@@ -2,42 +2,40 @@ defmodule Phone.CountriesTest do
   use ExUnit.Case, async: true
 
   main_module = Phone.Countries
-  all_modules = [
-    Phone.AD, Phone.AE, Phone.AF, Phone.AL, Phone.AM, Phone.AO,
-    Phone.AR, Phone.AT, Phone.AU, Phone.AW, Phone.AZ, Phone.BA,
-    Phone.BD, Phone.BE, Phone.BG, Phone.BH, Phone.BI, Phone.BJ,
-    Phone.BN, Phone.BO, Phone.BR, Phone.BT, Phone.BW, Phone.BY,
-    Phone.BZ, Phone.CD, Phone.CF, Phone.CG, Phone.CH, Phone.CI,
-    Phone.CK, Phone.CL, Phone.CM, Phone.CN, Phone.CO, Phone.CR,
-    Phone.CU, Phone.CV, Phone.CW, Phone.CY, Phone.CZ, Phone.DE,
-    Phone.DJ, Phone.DK, Phone.DZ, Phone.EC, Phone.EE, Phone.EG,
-    Phone.ER, Phone.ES, Phone.ET, Phone.FI, Phone.FJ, Phone.FM,
-    Phone.FO, Phone.FR, Phone.GA, Phone.GB, Phone.GE, Phone.GF,
-    Phone.GH, Phone.GI, Phone.GL, Phone.GM, Phone.GN, Phone.GQ,
-    Phone.GR, Phone.GT, Phone.GW, Phone.GY, Phone.HK, Phone.HN,
-    Phone.HR, Phone.HT, Phone.HU, Phone.ID, Phone.IE, Phone.IL,
-    Phone.IN, Phone.IO, Phone.IQ, Phone.IR, Phone.IS, Phone.IT,
-    Phone.JO, Phone.JP, Phone.KE, Phone.KG, Phone.KH, Phone.KI,
-    Phone.KM, Phone.KP, Phone.KR, Phone.KW, Phone.KZ, Phone.LA,
-    Phone.LB, Phone.LI, Phone.LK, Phone.LR, Phone.LS, Phone.LT,
-    Phone.LU, Phone.LV, Phone.LY, Phone.MA, Phone.MC, Phone.MD,
-    Phone.ME, Phone.MG, Phone.MH, Phone.MK, Phone.ML, Phone.MM,
-    Phone.MN, Phone.MO, Phone.MQ, Phone.MR, Phone.MT, Phone.MU,
-    Phone.MV, Phone.MW, Phone.MX, Phone.MY, Phone.MZ, Phone.NA,
-    Phone.NC, Phone.NE, Phone.NG, Phone.NI, Phone.NL, Phone.NO,
-    Phone.NP, Phone.NR, Phone.NU, Phone.NZ, Phone.OM, Phone.PA,
-    Phone.PE, Phone.PF, Phone.PG, Phone.PH, Phone.PK, Phone.PL,
-    Phone.PM, Phone.PS, Phone.PT, Phone.PW, Phone.PY, Phone.QA,
-    Phone.RO, Phone.RS, Phone.RU, Phone.RW, Phone.SA, Phone.SB,
-    Phone.SC, Phone.SD, Phone.SE, Phone.SG, Phone.SH, Phone.SI,
-    Phone.SK, Phone.SL, Phone.SM, Phone.SN, Phone.SO, Phone.SR,
-    Phone.SS, Phone.ST, Phone.SV, Phone.SY, Phone.SZ, Phone.TD,
-    Phone.TG, Phone.TH, Phone.TJ, Phone.TK, Phone.TL, Phone.TM,
-    Phone.TN, Phone.TO, Phone.TR, Phone.TV, Phone.TW, Phone.TZ,
-    Phone.UA, Phone.UG, Phone.UY, Phone.UZ, Phone.VE, Phone.VN,
-    Phone.VU, Phone.WF, Phone.WS, Phone.YE, Phone.ZA, Phone.ZM,
-    Phone.ZW, Phone.NANP
-  ]
+  all_modules = [Phone.AD, Phone.AE, Phone.AF, Phone.AL, Phone.AM, Phone.AO,
+                 Phone.AR, Phone.AT, Phone.AU, Phone.AW, Phone.AZ, Phone.BA,
+                 Phone.BD, Phone.BE, Phone.BG, Phone.BH, Phone.BI, Phone.BJ,
+                 Phone.BN, Phone.BO, Phone.BR, Phone.BT, Phone.BW, Phone.BY,
+                 Phone.BZ, Phone.CD, Phone.CF, Phone.CG, Phone.CH, Phone.CI,
+                 Phone.CK, Phone.CL, Phone.CM, Phone.CN, Phone.CO, Phone.CR,
+                 Phone.CU, Phone.CV, Phone.CW, Phone.CY, Phone.CZ, Phone.DE,
+                 Phone.DJ, Phone.DK, Phone.DZ, Phone.EC, Phone.EE, Phone.EG,
+                 Phone.ER, Phone.ES, Phone.ET, Phone.FI, Phone.FJ, Phone.FM,
+                 Phone.FO, Phone.FR, Phone.GA, Phone.GB, Phone.GE, Phone.GF,
+                 Phone.GH, Phone.GI, Phone.GL, Phone.GM, Phone.GN, Phone.GQ,
+                 Phone.GR, Phone.GT, Phone.GW, Phone.GY, Phone.HK, Phone.HN,
+                 Phone.HR, Phone.HT, Phone.HU, Phone.ID, Phone.IE, Phone.IL,
+                 Phone.IN, Phone.IO, Phone.IQ, Phone.IR, Phone.IS, Phone.IT,
+                 Phone.JO, Phone.JP, Phone.KE, Phone.KG, Phone.KH, Phone.KI,
+                 Phone.KM, Phone.KP, Phone.KR, Phone.KW, Phone.KZ, Phone.LA,
+                 Phone.LB, Phone.LI, Phone.LK, Phone.LR, Phone.LS, Phone.LT,
+                 Phone.LU, Phone.LV, Phone.LY, Phone.MA, Phone.MC, Phone.MD,
+                 Phone.ME, Phone.MG, Phone.MH, Phone.MK, Phone.ML, Phone.MM,
+                 Phone.MN, Phone.MO, Phone.MQ, Phone.MR, Phone.MT, Phone.MU,
+                 Phone.MV, Phone.MW, Phone.MX, Phone.MY, Phone.MZ, Phone.NA,
+                 Phone.NC, Phone.NE, Phone.NG, Phone.NI, Phone.NL, Phone.NO,
+                 Phone.NP, Phone.NR, Phone.NU, Phone.NZ, Phone.OM, Phone.PA,
+                 Phone.PE, Phone.PF, Phone.PG, Phone.PH, Phone.PK, Phone.PL,
+                 Phone.PM, Phone.PS, Phone.PT, Phone.PW, Phone.PY, Phone.QA,
+                 Phone.RO, Phone.RS, Phone.RU, Phone.RW, Phone.SA, Phone.SB,
+                 Phone.SC, Phone.SD, Phone.SE, Phone.SG, Phone.SH, Phone.SI,
+                 Phone.SK, Phone.SL, Phone.SM, Phone.SN, Phone.SO, Phone.SR,
+                 Phone.SS, Phone.ST, Phone.SV, Phone.SY, Phone.SZ, Phone.TD,
+                 Phone.TG, Phone.TH, Phone.TJ, Phone.TK, Phone.TL, Phone.TM,
+                 Phone.TN, Phone.TO, Phone.TR, Phone.TV, Phone.TW, Phone.TZ,
+                 Phone.UA, Phone.UG, Phone.UY, Phone.UZ, Phone.VE, Phone.VN,
+                 Phone.VU, Phone.WF, Phone.WS, Phone.YE, Phone.ZA, Phone.ZM,
+                 Phone.ZW, Phone.NANP]
 
   Enum.map(main_module.codes,
     fn code ->

diff --git a/test/phone/us_test.exs b/test/phone/us_test.exs
@@ -3,21 +3,19 @@ defmodule Phone.USTest do
 
   main_module = Phone.NANP.US
 
-  all_modules = [
-    Phone.NANP.US.AK, Phone.NANP.US.AL, Phone.NANP.US.AR, Phone.NANP.US.AZ,
-    Phone.NANP.US.CA, Phone.NANP.US.CO, Phone.NANP.US.CT, Phone.NANP.US.DC,
-    Phone.NANP.US.DE, Phone.NANP.US.FL, Phone.NANP.US.GA, Phone.NANP.US.HI,
-    Phone.NANP.US.IA, Phone.NANP.US.ID, Phone.NANP.US.IL, Phone.NANP.US.IN,
-    Phone.NANP.US.KS, Phone.NANP.US.KY, Phone.NANP.US.LA, Phone.NANP.US.MA,
-    Phone.NANP.US.MD, Phone.NANP.US.ME, Phone.NANP.US.MI, Phone.NANP.US.MN,
-    Phone.NANP.US.MO, Phone.NANP.US.MS, Phone.NANP.US.MT, Phone.NANP.US.NC,
-    Phone.NANP.US.ND, Phone.NANP.US.NE, Phone.NANP.US.NH, Phone.NANP.US.NJ,
-    Phone.NANP.US.NM, Phone.NANP.US.NV, Phone.NANP.US.NY, Phone.NANP.US.OH,
-    Phone.NANP.US.OK, Phone.NANP.US.OR, Phone.NANP.US.PA, Phone.NANP.US.RI,
-    Phone.NANP.US.SC, Phone.NANP.US.SD, Phone.NANP.US.TN, Phone.NANP.US.TX,
-    Phone.NANP.US.UT, Phone.NANP.US.VT, Phone.NANP.US.VA, Phone.NANP.US.WA,
-    Phone.NANP.US.WI, Phone.NANP.US.WV, Phone.NANP.US.WY
-  ]
+  all_modules = [Phone.NANP.US.AK, Phone.NANP.US.AL, Phone.NANP.US.AR, Phone.NANP.US.AZ,
+                 Phone.NANP.US.CA, Phone.NANP.US.CO, Phone.NANP.US.CT, Phone.NANP.US.DC,
+                 Phone.NANP.US.DE, Phone.NANP.US.FL, Phone.NANP.US.GA, Phone.NANP.US.HI,
+                 Phone.NANP.US.IA, Phone.NANP.US.ID, Phone.NANP.US.IL, Phone.NANP.US.IN,
+                 Phone.NANP.US.KS, Phone.NANP.US.KY, Phone.NANP.US.LA, Phone.NANP.US.MA,
+                 Phone.NANP.US.MD, Phone.NANP.US.ME, Phone.NANP.US.MI, Phone.NANP.US.MN,
+                 Phone.NANP.US.MO, Phone.NANP.US.MS, Phone.NANP.US.MT, Phone.NANP.US.NC,
+                 Phone.NANP.US.ND, Phone.NANP.US.NE, Phone.NANP.US.NH, Phone.NANP.US.NJ,
+                 Phone.NANP.US.NM, Phone.NANP.US.NV, Phone.NANP.US.NY, Phone.NANP.US.OH,
+                 Phone.NANP.US.OK, Phone.NANP.US.OR, Phone.NANP.US.PA, Phone.NANP.US.RI,
+                 Phone.NANP.US.SC, Phone.NANP.US.SD, Phone.NANP.US.TN, Phone.NANP.US.TX,
+                 Phone.NANP.US.UT, Phone.NANP.US.VT, Phone.NANP.US.VA, Phone.NANP.US.WA,
+                 Phone.NANP.US.WI, Phone.NANP.US.WV, Phone.NANP.US.WY]
 
   Enum.map(main_module.codes,
     fn code ->