Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃嚜馃嚫 Added area codes for Spain #132

Merged
merged 2 commits into from Apr 29, 2020

Conversation

luhalvesbr
Copy link
Contributor

-> Area code for 50 provincies in Spain
-> Special cases named "Intelligent Numbers"

-> Area code for 50 provincies in Spain
-> Special cases named "Intelligent Numbers"
@sourcelevel-bot
Copy link

Hello, @luhalvesbr! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

README.md Outdated Show resolved Hide resolved
@luhalvesbr
Copy link
Contributor Author

Here we have the main document I based to fill the rules
(It's in Spanish, however, as the rules are mostly numbers, I guess it won't be a problem if you want to take a look)

https://avancedigital.gob.es/es-ES/Servicios/Numeracion/Documents/Guia_Numeracion.pdf

On page 27th,
We have the table with every single province in Spain and the respective telephone numbers prefix.

On pages 5-11 (Mainly page 6),
We have the types of "intelligent numbers".
I did know exactly how I should proceed to add this special case and respect the created structure.
So, I just followed the same way you did for the Brazilian Toll-Free.
Let me know if you have something different in mind and we can adapt it.

@coveralls
Copy link

coveralls commented Apr 27, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 04d330d on LuhalvesBR:feature/spanish-area-codes into 53f19c6 on fcevado:master.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@sourcelevel-bot
Copy link

SourceLevel has finished reviewing this Pull Request and has found:

  • 4 possible new issues (including those that may have been commented here).
  • 3 fixed issues! 馃帀

See more details about this review.

@luhalvesbr
Copy link
Contributor Author

It asked me to add 2 spaces...
Then, after committing it asked to remove it...

Alt Text

Am I misunderstanding something?

@fcevado
Copy link
Owner

fcevado commented Apr 27, 2020

@luhalvesbr I'll take a look on why sourcelevel is bugging with the markdown stuff. no worries, I gonna do a full review of this change later today.

@fcevado fcevado merged commit cbdd4ef into fcevado:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants