add runFcitx5 button #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork
update fork
wengxt
requested changes
Nov 28, 2020
| @@ -41,6 +44,11 @@ void ErrorOverlay::availabilityChanged(bool avail) { | |||
| } | |||
| } | |||
|
|
|||
| void ErrorOverlay::runFcitx5() | |||
| { | |||
| system("fcitx5-autostart"); | |||
There was a problem hiding this comment.
- Just run fcitx5.
- don't use system().
See how FcitxModule::runFcitx() implement it.
| @@ -25,6 +26,8 @@ ErrorOverlay::ErrorOverlay(DBusProvider *dbus, QWidget *parent) | |||
| connect(baseWidget_, &QObject::destroyed, this, &QObject::deleteLater); | |||
| connect(dbus, &DBusProvider::availabilityChanged, this, | |||
| &ErrorOverlay::availabilityChanged); | |||
|
|
|||
| connect(ui_->pushButton,&QAbstractButton::pressed,this,&ErrorOverlay::runFcitx5); | |||
There was a problem hiding this comment.
Code is not properly formatted, please run clang-format.
| </widget> | ||
| </item> | ||
| <item> | ||
| <widget class="QPushButton" name="pushButton"> |
There was a problem hiding this comment.
maybe we can have a more descriptive name for this
chenshijie-uos
commented
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add runFcitx5 button