-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for TLS per-connection #334
Conversation
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 85.67% 85.86% +0.18%
==========================================
Files 11 11
Lines 1543 1563 +20
==========================================
+ Hits 1322 1342 +20
Misses 152 152
Partials 69 69
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stay by what I said here, it's much easier but adds one more field to the ClientHandler
.
... which is fine. I'll start a discussion about this topic and ways to reduce the bloating memory footprint.
@fclairamb I don't want to force you to accept this PR instead of #312. This is only to demostrate the alternative approach I proposed in #312. I prefer this one for the reasons explained there |
Sorry I forgot to answer. Both options are fine to me, I prefer this code though. |
Thanks, this code allows me to avoid checking if the property is set for the SFTPGo user every time a transfer connection is opened. I'll be adding this functionality to SFTPGo later today after a final code review |
Alternative approach to support TLS per-connection