Allow passing in an existing net.Listener and a public ip resolver. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fclairamb
requested changes
Dec 27, 2017
| @@ -74,6 +74,9 @@ type ClientContext interface { | |||
|
|
|||
| // Client's address | |||
| RemoteAddr() net.Addr | |||
|
|
|||
| // Servers's address | |||
| LocalAddr() net.Addr | |||
There was a problem hiding this comment.
Shouldn't we rename it to ListenAddr to make it a bit more explicit ?
There was a problem hiding this comment.
Im open to a name change, but figured it would make more sense to expose it under the same name as the connection object it is coming from.
Its also not guaranteed that the address is actually the same as the listener address (again from my use case, it will be the private IP of the load balancer that is forwarding the request).
I had originally written this (when prototyping for my own uses) to pass the net.Conn object to the PublicIPResolver, but figured that exposed too much, and instead opted to abstract it behind the ClientContext.
server/driver.go
Outdated
| @@ -90,11 +93,15 @@ type PortRange struct { | |||
| End int // Range end | |||
| } | |||
|
|
|||
| type PublicIpResolver func(ClientContext) (string, error) | |||
marshallbrekka
force-pushed
the
injectable-listener
branch
2 times, most recently
from
754e528
to
7b96678
Compare
marshallbrekka
force-pushed
the
injectable-listener
branch
from
7b96678
to
5890a0b
Compare
|
@fclairamb fixed linter issues |
fclairamb
approved these changes
Dec 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to provide the mechanisms to get the PASV command to work when running behind a load balancer that supports the proxy protocol by supplying a proxy protocol enabled net.Listener, and a PublicIpResolver that takes the ClientContext and returns the public ip to return to the client.
fclairamb/ftpserver#54