Check table names before creating them

[JJ]

Some table names are not acceptable, like the ones with - or, for some reason, "commit". Document acceptable table names and check for them in the create-table meta-method.

[FCO]

That’s a good idea, but maybe that should be a driver logic, once there’s didiferente reserved words for different databases.

[JJ]

But there's a module for common SQL things, right? Stuff like not using dashes should maybe go there.

[FCO]

Sure, but that should be extensible for specific drivers... but today the “-“ on a model type name is converted to “_”... it will only happens a table with “-“ on its name if some one do:

model Bla is table<name-with-dash> {...}

[JJ]

In my example, Git-commit gets translated to:

CREATE TABLE git-commit(
   subject varchar(255) NULL,
   hash varchar(255) NULL,
   body varchar(255) NULL,
   email varchar(255) NULL,
   created varchar(255) NULL
)

[JJ]

The regex only works if the letter behind the dash is in caps, apparently.

[FCO]

You are right! camel-to-snake-case doesn’t treaty -, I’m going to fix that!

[FCO]

I think this fixes the principal problem, but it would be great to test the reserved words for each driver.

Thanks!

[FCO]

Done! thanks!