Audit triplestore #6
Conversation
|
I assume |
|
Yes, I have been skipping tests for quick checks. Missed to run the tests after finishing the work. Will update with fixes for the tests. |
| @@ -12,7 +12,11 @@ | |||
| <cm:default-properties> | |||
| <cm:property name="jms.brokerUrl" value="tcp://localhost:61616"/> | |||
| <cm:property name="jms.fcrepoEndpoint" value="topic:fedora"/> | |||
| <cm:property name="triplestore.baseUrl" value="localhost:3030/ds/test"/> | |||
| <cm:property name="triplestore.baseUrl" value="localhost:3030/fedora4"/> | |||
There was a problem hiding this comment.
Is there any benefit to having two properties? Why not just make triplestore.baseUrl localhost:3030/fedora4/update?
There was a problem hiding this comment.
Agreed -- this should be a single property
|
:+1 this looks good to me & is working for me locally. |
|
Wait, looks like there's a merge conflict in the RouterTest -- can you rebase this? |
|
Sure, I will merge fcrepo-camel-toolkit:master to PR branch. |
|
👍 now it merges cleanly too – thanks @mohideen |
Audit triplestore workflow is now functional, fixes https://jira.duraspace.org/browse/FCREPO-1451
| @@ -62,7 +61,9 @@ | |||
| */ | |||
| public void process(final Exchange exchange) throws Exception { | |||
| final Message in = exchange.getIn(); | |||
| final UriRef eventURI = new UriRef("XXX"); | |||
| final String eventURIBase = (String) exchange.getProperty("eventURI.base"); | |||
There was a problem hiding this comment.
Does a mixed-case, String-literal property not seem risky?
There was a problem hiding this comment.
It's not particularly risky given that it's set in the EventRouter class from a property placeholder value. But wouldn't it make more sense to put the value in a header? (I realize that the distinction b/t header and property is a bit thin)
There was a problem hiding this comment.
I will leave the question of property vs. header up to you...
We can certainly leave eventURI.base as it is; however, I notice an existing convention along the lines of:
triplestore.baseUrl
Close, but different.
There was a problem hiding this comment.
yes, the property names should follow a more consistent naming pattern
Functional workflow: Camel picks up JMS events from fedora and updates Fuseki triplestore.