add support for fixing problems #4
Conversation
| @@ -231,15 +287,15 @@ private OcflObjectSessionFactory createObjectSessionFactory(final MutableOcflRep | |||
| objectMapper, | |||
| new CaffeineCache<>(headersCache), | |||
| new CaffeineCache<>(rootIdCache), | |||
| // TODO does this need to be an option? | |||
| CommitType.NEW_VERSION, | |||
| disableAutoVersioning ? CommitType.UNVERSIONED : CommitType.NEW_VERSION, | |||
There was a problem hiding this comment.
I haven't tried this yet, but if you have an auto-versioned repo and your disable autoversioning does that wreak havoc, same with vice-versa?
There was a problem hiding this comment.
It should be fine. If you have auto-versioning disabled and you enable it here, then it just means that it will commit the mutable head and create a new version when it fixes a problem. Conversely, if your repo has it enabled, and you disable it here then it will apply the fix to a new mutable head and not create a version. Next time you update the resource through Fedora it would then create a new version as normal.
But, yes, generally speaking, you probably want to use the same settings as you're using in Fedora, and, even if you have auto-versioning disabled in Fedora, I personally would probably auto-version here.
There was a problem hiding this comment.
Ok I might still give it a try to see the outcome. I agree that in general running fcrepo-doctor with auto-versioning makes the most sense. It is nice to see the change in the filesystem neatly packaged.
> rocfl show info:fedora/binary1 6
Version 6
Author: fedoraAdmin <info:fedora/fedoraAdmin>
Date: Sat, 21 May 2022 12:20:13 -0500
Message: Authored by Fedora 6
Operation Logical Path
Modified .fcrepo/fcr-root.json
Modified .fcrepo/fcr-root~fcr-desc.json
Modified binary1~fcr-desc.nt
> rocfl show info:fedora/binary1 7
Version 7
Author: fedoraAdmin <info:fedora/fedoraAdmin>
Date: Sat, 21 May 2022 12:24:50 -0500
Message: Generated by fcrepo-doctor
Operation Logical Path
Modified .fcrepo/fcr-root~fcr-desc.json
Modified binary1~fcr-desc.nt
What does this Pull Request do?
Adds support for fixing problems. Currently, this just means fixing binary descriptions with invalid subjects.
How should this be tested?
<info:fedora/resource/fcr:metadata>fcrepo-doctoras described in the READMEInterested parties
@fcrepo/committers