improve shutdown impl to work on java 17+ #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbernstein
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
The code looks good and builds locally. There is a problem with the CI build but that appears to be related to the fact that this project is still on Travis and needs to be migrated to github actions. I'll create a ticket for that and once I've confirmed all is well locally I will merge. Thank you @pwinckles !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
When I originally wrote the code that shutsdown the executor, I used reflection to get the info necessary to save the tasks that hadn't been processed. This will not work in Java 17+. This PR reworks the shutdown to no longer require reflection.
How to test
Start an export and abort it while it's still running using ctrl+c. Then, verify the inflight tasks were logged.