Add suppressions and remove legacy checkstyle.xml #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whikloj
approved these changes
May 16, 2019
There was a problem hiding this comment.
This builds, but as there is no way to test it I'll assume it will work with fcrepo/fcrepo#1526 and if not corrections can be made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://jira.duraspace.org/browse/FCREPO-2782
What does this Pull Request do?
Moves towards using the DuraSpace checkstyle rules.
In so doing, removes the legacy checkstyle.xml and adds additional suppressions for rules found in the DuraSpace checkstyle.
How should this be tested?
This can only be tested in conjunction with Fedora changes also associated with:
Related to: https://jira.duraspace.org/browse/FCREPO-2782
Interested parties
@fcrepo4/committers