Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local version of respec #158

Merged
merged 2 commits into from Jul 17, 2017
Merged

Add local version of respec #158

merged 2 commits into from Jul 17, 2017

Conversation

awoods
Copy link
Collaborator

@awoods awoods commented Jul 10, 2017

  • respec v14.0.13

Resolves: #152

Add local version of respec
2bd5220 
- respec v14.0.13

Resolves: fcrepo#152
zimeon
zimeon reviewed Jul 11, 2017
View reviewed changes
index.html Outdated
@@ -4,7 +4,7 @@
<title>Fedora API Specification</title>
<meta charset='utf-8'>
<meta name="description" content="Fedora API Specification">
<script src='https://www.w3.org/Tools/respec/respec-w3c-common'
<script src='http://fedora.info/spec/respec/v14.0.13/respec-w3c-common'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with a relative link. That way it will work with a locally checked out copy of the spec repo which I know I find convenient.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially had a relative link in the same directory as the index.html file. The reason a backed away from that was because browsing to the local index.html in the browser with file:// did not load the javascript.
But if others are ok with that limitation, I am happy to update.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The local file:// relative issue I described goes away if adding the .js suffix to respec-w3c-common.

zimeon
zimeon approved these changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@zimeon zimeon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (and I got a little education because I had to look up the class=remove)

@zimeon zimeon merged commit 9557e50 into fcrepo:master Jul 17, 2017
barmintor pushed a commit that referenced this pull request Jun 21, 2018
@zimeon @barmintor
Stab at fixing fcrepo styles for candidate and recommendation (#375)
f743016 
* Stab at fixing fcrepo styles for candidate and recommendation

* Address @awoods comments

* Change version to 1.0 to agree with discussion on #280/#334

* respec v14.0.13 cf #158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimeon zimeon zimeon approved these changes

@escowles escowles escowles approved these changes

@dannylamb dannylamb dannylamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@awoods @zimeon @escowles @dannylamb