Clarify headers and response code for external content #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeon
reviewed
Apr 5, 2018
index.html
Outdated
| <pre> | ||
| Link: <http://www.w3.org/ns/ldp#Resource>;rel="type" | ||
| Link: <http://www.w3.org/ns/ldp#NonRDFSource>;rel="type" | ||
| Link: <http://host/fcrepo/image/fcr:metadata>; rel="describedby" |
There was a problem hiding this comment.
Should we show these as separate Link headers or combine into one with commas? I think if we show separately we should add a note that they might be combined (per https://tools.ietf.org/html/rfc8288#section-3)
index.html
Outdated
| @@ -671,6 +681,10 @@ <h4>Redirected and Proxied External Content</h4> | |||
| <code>GET</code> and <code>HEAD</code> requests to any external <a>LDP-NR</a> MUST correctly | |||
| respond to the <code>Want-Digest</code> header defined in [[!RFC3230]]. | |||
| </p> | |||
| <p id='external-content-redirect-status'> | |||
| A successful response to external content with <code>handling</code> of <code>redirect</code> MUST have | |||
There was a problem hiding this comment.
response to a GET and HEAD request for external content?
zimeon
approved these changes
Apr 9, 2018
escowles
approved these changes
Apr 11, 2018
barmintor
approved these changes
Apr 11, 2018
dannylamb
approved these changes
Apr 11, 2018
barmintor
pushed a commit
to barmintor/fcrepo-specification
that referenced
this pull request
May 22, 2018
* Clarify headers and response code for external content Resolves: fcrepo#345 * Address code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #345