Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Resource Management introduction #364

Merged
merged 4 commits into from May 22, 2018
Merged

Adding Resource Management introduction #364

merged 4 commits into from May 22, 2018

Conversation

escowles
Copy link
Contributor

@escowles escowles commented May 7, 2018

Refs #356

@escowles
Copy link
Contributor Author

escowles commented May 7, 2018

I expect more wordsmithing here than in the main section 3 cleanup, so putting this in its own PR.

@escowles escowles added this to the Recommendation milestone May 7, 2018
awoods
awoods previously approved these changes May 9, 2018
index.html Outdated
</p>
<p>
[[!LDP]] defines a hierarchy of resources, with a top-level distinction between RDF resources
(<a>LDP-RS</a>) and non-RDF resources (<a>LDP-NR</a>). RDF resources are further divided into
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make it clear that not all RDF resources are containers. May also be easier to split into two sentence, something like:

RDF resources may function as containers (LDPC) of other resources. There are several container subtypes, which are primarily differentiated by how much the container-member relationship can be configured.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just pushed an update to split into two sentences.

zimeon
zimeon previously approved these changes May 9, 2018
@zimeon
Copy link
Contributor

zimeon commented May 9, 2018

Moving goalposts, no "Introduction" heading per #369

@escowles
Copy link
Contributor Author

Updated to remove Introduction header and use blockquoted style instead.

dannylamb
dannylamb previously approved these changes May 11, 2018
Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better

@barmintor barmintor merged commit 2b438b6 into fcrepo:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants