reduce node lookups in event processing #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,30 +110,42 @@ public void buildListener() throws RepositoryException { | |||
| @Override | |||
| public void onEvent(final javax.jcr.observation.EventIterator events) { | |||
| // keep track of nodes that trigger events to prevent duplicates | |||
| final Set<Node> posted = new HashSet<Node>(); | |||
| // size to minimize resizing. | |||
| final Set<String> posted = new HashSet<String>((int)events.getSize() * 2 / 3); | |||
There was a problem hiding this comment.
What is the rationale for sizing the Set to: (events.size * 2 / 3)? versus some other value?
There was a problem hiding this comment.
at an initial capacity of 2/3 max, and a load factor of 0.75, this should mean at most one resize of the set. We could size it accurately and set the load to 1, but my understanding is that performance is worse, and if we ignore some nodes we'l have slack anyway. Still, maybe not worth doing anything but setting the size to Math.min(16, (int)events.size())
There was a problem hiding this comment.
I trust your research and judgement in deciding between 2/3 or min(16). Thanks for providing the explanation.
|
Some minor comments, but otherwise looks good. |
awoods
pushed a commit
that referenced
this pull request
Nov 27, 2013
Reduce node lookups in event processing Resolves: https://www.pivotaltracker.com/story/show/61411396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/61411396
Reduce node lookups and stop using long-running sessions for look-ups in event processing