New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http api fixes #177
Http api fixes #177
Conversation
… displaying the content)
@@ -47,7 +52,7 @@ function addChild() | |||
} else { | |||
$.post(postURI, function(data, textStatus, request) { | |||
window.location = request.getResponseHeader('Location'); | |||
}); | |||
}).fail( ajaxErrorHandler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing an empty AJAX error dialog when creating an object fails. Can we add a descriptive error message like for datastreams?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fails how? I was testing unregistered namespaces and I'm pretty sure I saw the java stacktrace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bogus content seems to work correctly and result in a dialog with a stacktrace. But I'm seeing a completely blank dialog (no title, no content) when I stop fcrepo4, when I do any of the following: add object, delete object, delete datastream/object, sparql update, or start transaction. Stopping the repo seemed like the easiest way to simulate failure for the core add/delete/update operations -- but maybe the error handling here is assuming a response from the repo, not total failure?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. The AJAX modal is just serving up whatever content fcrepo4 returns. I think adding heartbeat logic would be nice, but I'd argue it's out of scope for this ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll create a followup ticket for handling repo non-response.
Improving error handling to HTML UI. Fixes #177
No description provided.