add user rdf types cache #1935
Merged
add user rdf types cache #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whikloj
reviewed
Sep 11, 2021
| assertThat(types, containsInAnyOrder(ANIMAL_TYPE)); | ||
|
|
||
| types = cache.getUserTypes(fedoraId, sessionId2, rdfSupplier(ANIMAL_TYPE, CAT_TYPE)); | ||
| assertThat(types, containsInAnyOrder(ANIMAL_TYPE, CAT_TYPE)); |
There was a problem hiding this comment.
I think I get what you mean here, but just wondering. If you called
types = cache.getUserTypes(fedoraId, sessionId2, noCallSupplier());
would types == emptyList()?
There was a problem hiding this comment.
No, because the noCallSupplier() throws an exception when it's called. It's just used in the tests to ensure that the values are returned from the cache and were not newly loaded.
dbernstein
approved these changes
Sep 16, 2021
dbernstein
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3732
What does this Pull Request do?
Adds a cache for user rdf types so that they do not need to be repeatedly loaded from disk.
How should this be tested?
Everything should work the same as before except triples should never be loaded from disk when creating or updating resources. I added a new debug log that will log every time a resource's triples are loaded. If you enable debug logging you should be able to confirm that the triples are no longer read when creating resources.
Key things to look at:
Interested parties
@fcrepo/committers