Make a query param to change content-disposition from attachment to inline #1956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3791 & https://fedora-repository.atlassian.net/browse/FCREPO-1843
What does this Pull Request do?
Adds a query parameter
inline
, that if set totrue
will result in the Content-Disposition being set toinline
. Otherwise it remainsattachment
This is also changed for HEAD requests, mementos and external content.
How should this be tested?
Add a binary to a repository using main.
GET the binary
Content-Disposition: attachment; size=79; creation-date="Wed, 24 Nov 2021 14:52:17 GMT"; modification-date="Wed, 24 Nov 2021 14:52:17 GMT"
headerPull in this PR
GET the binary
/fcr:metadata
and add?inline=true
you will immediately gets the content.?inline=true
and see theContent-Disposition: inline; size=79; creation-date="Wed, 24 Nov 2021 14:52:17 GMT"; modification-date="Wed, 24 Nov 2021 14:52:17 GMT"
header (might have to do a HEAD if you use an image as your binary)Interested parties
Tag (@ mention) interested parties or, if unsure, @fcrepo/committers