Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the HTML Search UI #1972

Merged
merged 13 commits into from Mar 24, 2022
Merged

Updates to the HTML Search UI #1972

merged 13 commits into from Mar 24, 2022

Conversation

mikejritter
Copy link
Contributor

JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3549 and https://fedora-repository.atlassian.net/browse/FCREPO-3551

What does this Pull Request do?

  • Add page controls to the search ui
  • Add field selection to the search ui
  • Allow multiple conditions when searching in the search ui

How should this be tested?

  • Start a Fedora instance
  • Add some resources
  • Navigate to http://localhost:8080/rest/fcr:search or where the search ui is located for your instance
  • Query using multiple conditions, and restricting the page/field display options

Interested parties

@fcrepo/committers

Copy link
Contributor

@dbernstein dbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @mikejritter .

Some things to make the UI a little easier to see:

  1. Can you put some kind of visual cue such as a horizontal line to separate one set of condition controls from another?

  2. Could you add a "Remove" button for each condition block so that you can easily modify the query if it isn't exactly what you thought you needed?

Copy link
Contributor

@dbernstein dbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment

@mikejritter
Copy link
Contributor Author

@dbernstein I updated the search conditions to display a bit cleaner and have a remove icon. Should probably still test again to make sure everything is still working.

Copy link
Contributor

@dbernstein dbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better. Thanks @mikejritter

@dbernstein dbernstein merged commit 828b4b9 into fcrepo:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants