New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the HTML Search UI #1972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @mikejritter .
Some things to make the UI a little easier to see:
-
Can you put some kind of visual cue such as a horizontal line to separate one set of condition controls from another?
-
Could you add a "Remove" button for each condition block so that you can easily modify the query if it isn't exactly what you thought you needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my previous comment
@dbernstein I updated the search conditions to display a bit cleaner and have a remove icon. Should probably still test again to make sure everything is still working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's better. Thanks @mikejritter
JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3549 and https://fedora-repository.atlassian.net/browse/FCREPO-3551
What does this Pull Request do?
How should this be tested?
http://localhost:8080/rest/fcr:search
or where the search ui is located for your instanceInterested parties
@fcrepo/committers