Timemaps should use the ACL of the original resource #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3825
What does this Pull Request do?
Timemaps are displaying a Link header for an ACL off of the Timemap (i.e.
RESOURCE/fcr:versions/fcr:aclinstead ofRESOURCE/fcr:acl). That is an invalid identifier and so it not accessible.This PR changes the link header to the Original Resource's ACL.
How should this be tested?
Before the PR, create any resource, get the Timemap and review the headers. See the
rel="acl"one.Pull in this PR and see how the Link header has changed.
Interested parties
@fcrepo/committers