Use Set to deduplicate any extra versions #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpennel
approved these changes
Jun 2, 2022
dbernstein
added a commit
that referenced
this pull request
Jun 9, 2022
This reverts commit 69e1fc4.
|
I accidentally merged this into 6.2.0-RC . I will push this to a new PR based on main: #1998 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3655
What does this Pull Request do?
Fixes the
application/link-formatoutput when there are more than one version in a second. The RDF formats seem to automatically deduplicate, but we manually generate this format.How should this be tested?
This is most obvious with an automated script because you need to generate more than one version in a single second.
GETthe Timemap (/fcr:versions) astext/turtleand see only one version per second.Accept: application/link-formatand see duplicate versions.Interested parties
@fcrepo/committers