Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a bad request for invalid fields in simple search #2005

Merged
merged 1 commit into from Aug 18, 2022

Conversation

mikejritter
Copy link
Contributor

JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3828

What does this Pull Request do?

Return a bad request for invalid fields in simple search

How should this be tested?

  • Ensure the integration test passes: mvn clean verify
  • Build the one click application: mvn install -pl fcrepo-webapp -P one-click
  • Run the one click app: java -jar fcrepo-webapp/target/fcrepo-webapp-6.3.0-SNAPSHOT-jetty-console.jar
  • Query the search API with an invalid search field: curl --verbose "http://localhost:8080/rest/fcr:search?condition=blob_size<=12"
  • Check that the response from the above request is a 400

Interested parties

@fcrepo/committers

Copy link
Contributor

@dbernstein dbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Mike.

@dbernstein dbernstein merged commit ea84038 into fcrepo:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants