Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffer when reading input stream during fixity check #2025

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

mikejritter
Copy link
Contributor

JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3872

What does this Pull Request do?

  • Adds a buffer when reading input streams during fixity check

How should this be tested?

  • Ingest a largeish binary
    • If needed one is provided in the ticket
  • Call fcr:fixity on the ingested binary
    • e.g. curl -u fedoraAdmin:fedoraAdmin http://localhost:8080/rest/binary-id/fcr:fixity
    • time curl ... can be used to note the amount of time the call takes
  • Build + run the changes from this PR
  • Rerun the curl call on fcr:fixity and compare the response times

Notes

Buffer size was informed by guava

Interested parties

Tag (@ mention) interested parties or, if unsure, @fcrepo/committers

Copy link

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mikejritter, this definitely makes a huge improvement -- in my test environment, fixity on my large file takes 8 seconds instead of 90 seconds now!

@bbpennel bbpennel merged commit f238310 into fcrepo:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants