Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other resources part to NonRdfSourceDescription HTML template #2046

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

whikloj
Copy link
Collaborator

@whikloj whikloj commented Sep 11, 2023

JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3904

What does this Pull Request do?

You can have a hash uri in the metadata of a binary. It displays except when you view the HTML UI. This is because the velocity templates don't currently display these other properties.

How should this be tested?

Create a binary and update the metadata with a hash uri.
i.e.

> curl -ufedoraAdmin:fedoraAdmin -v -H"Content-type: image/jpeg" -d "@test_image.jpg" -H"Slug: test_image" -XPOST http://localhost:8080/rest

> curl -ufedoraAdmin:fedoraAdmin -v -XPATCH -d " INSERT DATA { <#somePart> <http://purl.org/dc/elements/1.1/title> 'Some part' . <> <http://purl.org/dc/elements/1.1/title> 'Binary thing' . }" -H"Content-type: application/sparql-update" http://localhost:8080/rest/test_image/fcr:metadata

View the binary description RDF as non-HTML

> curl -ufedoraAdmin:fedoraAdmin -v http://localhost:8080/rest/test_image/fcr:metadata

and view it through a web browser at the URL

Before the PR, you will see the <http://localhost:8080/rest/test_image#somePart> <http://purl.org/dc/elements/1.1/title> "Some part" . triple in the non-HTML, but in your web browser it will be missing.

Stop Fedora.
Pull in the PR and build it.
Restart your Fedora.

In the browser you will now see "Some part" under "Other Resources", the non-HTML is unaffected.

Interested parties

Tag (@ mention) interested parties or, if unsure, @fcrepo/committers and @tomcbe

Copy link
Contributor

@Surfrdan Surfrdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Surfrdan Surfrdan merged commit b82389d into fcrepo:main Oct 5, 2023
7 checks passed
@whikloj whikloj deleted the FCREPO-3904 branch October 18, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants